Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci.yaml and pr.yaml update #6218

Merged
merged 3 commits into from
Aug 11, 2024
Merged

ci.yaml and pr.yaml update #6218

merged 3 commits into from
Aug 11, 2024

Conversation

heylf
Copy link
Contributor

@heylf heylf commented Aug 9, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@heylf
Copy link
Contributor Author

heylf commented Aug 9, 2024 •
edited
Loading

This is in connection with #6191

@bgruening

@bgruening
Copy link
Member

@mvdbeek is this ok, or can we get a new planemo release: #6191 (comment)

It could be that Leonid meant a new release of galaxy-tool

@mvdbeek
Copy link
Member

mvdbeek commented Aug 11, 2024

I don't see any related changes in galaxy-tool-util ? I've created a new planemo release which updates the galaxy package pins.

@kostrykin
Copy link
Contributor

I don't see any related changes in galaxy-tool-util ? I've created a new planemo release which updates the galaxy package pins.

Not sure whether this is already clear here or not, but the new planemo release is required to have these changes: galaxyproject/planemo#1471 @mvdbeek

bgruening
bgruening approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this has not helped. Lets add it for the time being.

@bgruening bgruening merged commit 30843d2 into galaxyproject:main Aug 11, 2024
11 checks passed
@bgruening
Copy link
Member

Thanks @mvdbeek!

@mvdbeek
Copy link
Member

mvdbeek commented Aug 11, 2024

Attention: deployment skipped!

https://github.com/galaxyproject/tools-iuc/actions/runs/10342483720

@mvdbeek
Copy link
Member

mvdbeek commented Aug 12, 2024

Like I said, I did create a new planemo release, https://pypi.org/project/planemo/0.75.25/. Let me know if you need anything else.

@mvdbeek mvdbeek mentioned this pull request Aug 12, 2024
Merged
5 tasks
@mvdbeek
Copy link
Member

mvdbeek commented Aug 12, 2024

What I'm seeing in @heylf's PR is https://github.com/galaxyproject/tools-iuc/pull/6191/files#r1713360682. I do see pillow and tifffile getting installed, so I think galaxy-tool-util or planemo is not at fault.

mvdbeek added a commit that referenced this pull request Aug 12, 2024
@mvdbeek
Revert "ci.yaml and pr.yaml update (#6218)"
8ab9604 
This reverts commit 30843d2.
@mvdbeek mvdbeek mentioned this pull request Aug 12, 2024
Merged
bgruening pushed a commit that referenced this pull request Aug 21, 2024
@mvdbeek
Revert "ci.yaml and pr.yaml update (#6218)" (#6228)
3c21a75 
This reverts commit 30843d2.
nilchia pushed a commit to pavanvidem/tools-iuc that referenced this pull request Aug 24, 2024
@heylf @nilchia
ci.yaml and pr.yaml update (galaxyproject#6218)
d2c430f 
* update ci.yaml

* update pr.yaml

* forget -
nilchia pushed a commit to pavanvidem/tools-iuc that referenced this pull request Aug 24, 2024
@mvdbeek @nilchia
Revert "ci.yaml and pr.yaml update (galaxyproject#6218)" (galaxyproje…
7beda27 
…ct#6228)

This reverts commit 30843d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heylf @bgruening @mvdbeek @kostrykin